Migrates existing login keyring entries to unencrypted default keyring#74
Open
rolandboon wants to merge 1 commit intomainfrom
Open
Migrates existing login keyring entries to unencrypted default keyring#74rolandboon wants to merge 1 commit intomainfrom
rolandboon wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #68. The previous migration created a password-less Default_keyring, but left the existing encrypted login.keyring untouched. Apps like Slack and Chrome still had their credentials in that encrypted keyring, so users kept getting a password prompt on launch.
This migration replaces the encrypted login.keyring with an unencrypted version. Apps will need to re-authenticate once after a reboot.
Why an unencrypted keyring is fine here: