Skip to content

Conversation

@fabiankaegy
Copy link
Member

This pull request makes a minor update to the ESLint workflow configuration. The change ensures that the linter uses the correct configuration file and ignores the dist directory during linting.

Closes #201

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the ESLint GitHub Actions workflow to explicitly specify the ESLint configuration file and exclude the dist directory from linting. The change addresses issue #201 by preventing the linter from checking compiled/built JavaScript files.

  • Adds explicit eslint_flags parameter to the reviewdog ESLint action
  • Configures ESLint to use .eslintrc.js as the configuration file
  • Ignores the dist/** directory pattern during linting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@claytoncollie
Copy link
Contributor

@fabiankaegy I understand passing the flag to make sure the correct config is used but shouldn't the dist ignore be in the eslint.js file so that it is also ignored when you use the pre-commit hooks or the npm commands manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESLint Linting Action reports errors on dist files

2 participants