Skip to content

Conversation

@peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Jan 15, 2026

Description of the Change

  • Update node version to version 20 (nvmrc)
  • Update NPM dependencies via npm audit fix.
  • Update WP-Env, -Scripts and -ESlint-plugin packages to latest versions
  • Update Cypress, Cypress-WP-Utils to latest version
  • Update mochawesome packages

The eslint upgrade started throwing some errors so I've fixed those via the --fix tag.

@fabiankaegy there are a few source code changes in this so you might want to take a look:

  • fixed linting errors
  • Fixed missing dependencies in react hooks.

How to test the Change

This ended up being a lot more than was required for the other repos:

  1. Build, WP-Env, Cypress verified by passing E2E tests
  2. Run npm ci
  3. Run npm run start
  4. Ensure editing the scss file triggers a build
  5. Ensure editing the JS files triggers a build
  6. Run npm run lint:css; npm run lint:js and ensure no errors are reported

Testing the plugin:

  1. Ensure settings can be saved:
    1. Valid settings display the message verifying the creds are correct
    2. Invalid settings display the message the creds are incorrect
  2. Create a block post
  3. Add the Apple Maps Block
  4. Ensure the block can be inserted and the controls work as expected
  5. Remove the credentials
  6. Create a block post
  7. Add the Apple Maps Block
  8. Ensure the message is displayed warning of invalid credentials
  9. Note: saving from the block is currently broken, see Saving credentials from block shows error, creds are saved. #253

Changelog Entry

Fixed - Add missing dependencies to React hooks.
Changed - Update node version for building plugin to version 20.
Changed - Update NPM dependencies via npm audit fix.
Developer - Update WP-Env to 10.37.0
Developer - Update WP-Scripts to 31.2.0
Developer - Update WP-ESlint-plugin to 23.0.0
Developer - Update Cypress-WP-Utils to 0.6.0
Developer - Update Cypress to 15.9.0
Developer - Update cypress-mochawesome-reporter to 3.8.4
Developer - Update mochawesome-json-to-md to 2.1.1

Credits

Props @peterwilsoncc

Checklist:

@github-actions github-actions bot added this to the 1.2.0 milestone Jan 15, 2026
@peterwilsoncc peterwilsoncc force-pushed the update-npm-dependencies branch 2 times, most recently from 367c97f to 78a2b53 Compare January 15, 2026 03:49
@peterwilsoncc peterwilsoncc force-pushed the update-npm-dependencies branch from 78a2b53 to ffa6f40 Compare January 15, 2026 03:52
@peterwilsoncc peterwilsoncc force-pushed the update-npm-dependencies branch from 2130d3a to 598749f Compare January 15, 2026 22:19
@peterwilsoncc peterwilsoncc marked this pull request as ready for review January 15, 2026 23:10
@github-actions github-actions bot added the needs:code-review This requires code review. label Jan 15, 2026
jobs:
build:
uses: 10up/maps-block-apple/.github/workflows/build-release-zip.yml@develop
uses: ./.github/workflows/build-release-zip.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason this was always using the develop branch or is it legacy code before GitHub supported using paths for actions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine almost certainly code that's been here long enough that GitHub may not have supported this approach then but happy to change this up now

@dkotter dkotter merged commit f8228f5 into develop Jan 16, 2026
18 of 19 checks passed
@dkotter dkotter deleted the update-npm-dependencies branch January 16, 2026 14:49
@peterwilsoncc peterwilsoncc restored the update-npm-dependencies branch January 18, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:code-review This requires code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants