-
Notifications
You must be signed in to change notification settings - Fork 5
Update npm dependencies #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
367c97f to
78a2b53
Compare
78a2b53 to
ffa6f40
Compare
2130d3a to
598749f
Compare
| jobs: | ||
| build: | ||
| uses: 10up/maps-block-apple/.github/workflows/build-release-zip.yml@develop | ||
| uses: ./.github/workflows/build-release-zip.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason this was always using the develop branch or is it legacy code before GitHub supported using paths for actions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would imagine almost certainly code that's been here long enough that GitHub may not have supported this approach then but happy to change this up now
Description of the Change
The eslint upgrade started throwing some errors so I've fixed those via the
--fixtag.@fabiankaegy there are a few source code changes in this so you might want to take a look:
How to test the Change
This ended up being a lot more than was required for the other repos:
npm cinpm run startnpm run lint:css; npm run lint:jsand ensure no errors are reportedTesting the plugin:
Changelog Entry
Credits
Props @peterwilsoncc
Checklist: