Skip to content
This repository was archived by the owner on May 2, 2024. It is now read-only.

Conversation

@felipeelia
Copy link
Member

Include the --include_files --include_db flags in the wpsnapshots pull call.

Description of the Change

Without those, the command will wait for a user input that will never come.

Include the ` --include_files --include_db` flags
@jeffpaul jeffpaul requested a review from tlovett1 January 15, 2021 18:35
@jeffpaul jeffpaul added this to the 0.16.10 milestone Jan 15, 2021
@jeffpaul jeffpaul changed the base branch from master to develop March 5, 2021 17:42
Remove the value for the `--overwrite_local_copy` flag
@dinhtungdu
Copy link
Contributor

This is blocking the WPAcceptance test on CI because wpsnapshots in the docker image has been updated to the latest version.

@dinhtungdu
Copy link
Contributor

@tlovett1 Please consider merging this PR and update the wpacceptance docker image so we can continue running WPA for 10up's open-source plugins. Currently, WPA tests of plugins using snapshots are failing because the pull command requires passing all arguments.

@dinhtungdu
Copy link
Contributor

Applying this PR, @thrijith found another issue while working on the A11y Checkup plugin, which I can reproduce on my end.

Warning: rmdir(/root/.wpsnapshots/a3f2959614a18989ea365da4d86945f1/): Device or resource busy in /root/.composer/vendor/10up/wpsnapshots/src/utils.php on line 359

SSH into the container, I got the same error trying to delete the folder manually:

root@d4165de11326:~/.wpsnapshots# rm -rf a3f2959614a18989ea365da4d86945f1/
rm: cannot remove 'a3f2959614a18989ea365da4d86945f1/': Device or resource busy

This issue only happens inside wpa container, I can pull with --overwrite_local_copy on the host machine flawlessly.

IMO, the best way to solve this issue is allowing bypass --overwrite_local_copy. Currently, that flag doesn't accept any value, so there is no way to skip overwriting the local snapshot inside WPA docker container.

@dinhtungdu
Copy link
Contributor

I created a PR to fix the overwriting local snapshot issue: 10up/wpsnapshots#86.

@felipeelia After the 86 is merged, can you please revert the change in fdbdf8d?

@felipeelia felipeelia removed their assignment Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants