Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@benlk
Copy link

@benlk benlk commented Apr 27, 2022

Description of the Change

Replaces valid, functioning third-party email addresses with ones that do not have a resolvable TLD. The .invalid TLD is reserved by IETF in BCP 32/RFC 2606 and will never route.

  ".invalid" is intended for use in online construction of domain
 names that are sure to be invalid and which it is obvious at a
 glance are invalid.

Closes #

Alternate Designs

An alternate design would be to replace these domain names with a dedicated domain name that is owned by 10up.

Possible Drawbacks

Errors may be thrown by WordPress if WordPress tries to send mail to these servers.

Verification Process

Unverified.

To verify, check out this branch and create a snasphot using it, then load the snapshot and verify that all users have email addresses with .invalid as the TLD.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

@benlk benlk self-assigned this Apr 27, 2022
@jeffpaul jeffpaul requested a review from tlovett1 April 27, 2022 16:27
@jeffpaul jeffpaul added this to the 2.2.1 milestone Apr 27, 2022
Copy link
Contributor

@tlovett1 tlovett1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll get this merged into the next release

@benlk
Copy link
Author

benlk commented Aug 11, 2023

@tlovett1 Is there anything else needed for this PR?

@psorensen
Copy link
Contributor

Similar task, different approach: #96

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants