Skip to content
This repository was archived by the owner on Sep 19, 2021. It is now read-only.

Conversation

@suzubara
Copy link
Contributor

@suzubara suzubara commented Sep 17, 2019

Description

This branch is a proof of concept of how to go about building new form input components, and hook them up to the section errors that come from Redux. It is for demo purposes and should not be merged as-is.

  • I created some new, simpler components for text input, checkbox, and select.
  • Started an HOC that can be used to standardize form inputs components, event handling, and rendering inside of a "formfield" layout (intended to replace the existing Field component).
  • Wrote some functions to help map validation models to input components so they can be used to inform native HTML5 attributes that handle input validation.
  • Show how these components could work together in a new NameFieldset component (demo'd side by side the existing Name component on the Applicant Name section).

Checklist for Reviewer

  • Review code changes
  • Review changes for Database effects
  • Verify change works in IE browser

More details about this can be found in docs/review.md

@suzubara suzubara requested a review from leonged September 18, 2019 21:02
@ryanhofdotgov ryanhofdotgov mentioned this pull request Dec 18, 2019
@ryanhofdotgov
Copy link
Contributor

Replaced by #1887 – Truss folks have been closing out their old PRs and I'd like to keep this prominent for a little longer.

@leonged
Copy link
Contributor

leonged commented Dec 18, 2019 via email

@ryanhofdotgov ryanhofdotgov deleted the sr-3887-ui-refactor-demo branch December 18, 2019 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants