fix: update deployContract to use generics for constructor args with arrays #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes type mismatch when passing arrays (e.g., readonly number[]) to deployContract constructor parameters. Implemented Solution B using generics with Abi type parameter to align with ContractFactory.deploy types. The function now accepts arrays and complex types in constructor parameters, resolving the issue where Array<BigNumberish> didn't match ContractFactory.deploy(...args: ContractMethodArgs<A>). Related Issues: 1inch#208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes type mismatch error when passing arrays (e.g.,
readonly [100, 500, 3000, 10000]) as constructor parameters todeployContract.The previous type
Array<BigNumberish>was too restrictive and didn't matchContractFactory.deploy(...args: ContractMethodArgs<A>)when arrays were included in constructor parameters.Changes
deployContractfunction to use generics withAbitype parameter (Solution B)Array<BigNumberish>toreadonly any[]to allow arrays and complex typesDeployContractParametersandDeployContractReturnfor better type safetyreadonly [100, 500, 3000, 10000]as constructor parametersTesting
Related Issues
Fixes #208
Potenrial reviewers: @mayar-deeb-xi @k06a @ZumZoom
Type of Change