Old IE needs to restart interval#1
Open
WelcomWeb wants to merge 1 commit into1uptalent:swipe2from
WelcomWeb:internet-explorer
Open
Old IE needs to restart interval#1WelcomWeb wants to merge 1 commit into1uptalent:swipe2from WelcomWeb:internet-explorer
WelcomWeb wants to merge 1 commit into1uptalent:swipe2from
WelcomWeb:internet-explorer
Conversation
Member
|
Thanks! You probably want to submit the pull request also to the original Swipe author: https://github.com/bradbirdsall/Swipe This fork is outdated and serves mostly for our own purposes (fixing https://github.com/bradbirdsall/Swipe/issues/43). I'll review the change and try to sync with upstream, hopefully next week. |
Author
|
Oh, thanks. Didn't look into it enough - I see now that there's a Swipe2 branch on the original repo. Will do a pull request there as well! Edit; and now I see that I can't fork the original repo because you forked from the original source :-) will you do a pull request upwards, or should I remove my fork of Swipe2 and redo it for Swipe? Sorry for the inconvenience, I'm blaming a couple of beers after a full working day ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some problems with Swipe2 and Internet Explorer <=IE9, it was only a restart of the main interval that was needed.