This repository was archived by the owner on Oct 14, 2025. It is now read-only.
fix(content): add npc_walk(npc_coord)'s to npc_setmode(none)'s #1759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2025 00:49
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of this is old code. Previously this code relied on npc_setmode(none) clearing the npc's destination tile. Recent engine changes removed this, so I'm adding the destination tile clearing in runescript with this pr.
Related runescript pic:
This pic at least hints that npc_setmode(none) doesnt clear the npc's destination, and that its common practice to bundle npc_walk(npc_coord) with npc_setmode(none)