Open
Conversation
luigi-rosso
approved these changes
Jan 2, 2020
Contributor
luigi-rosso
left a comment
There was a problem hiding this comment.
This is cleaner, thank you. I'm curious though, how was the provider returning null prior to these changes?
Collaborator
Author
|
@luigi-rosso it's about error handling, AFAIK, there are two ways to fail:
I was thinking that we should suppress the exception for invalid ByteData, but after a second thought, I think it's also ok to raise it, WDYT? So I'm going to hold this PR for now.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up PR for #202