🐛 - Fixed a bug in flare_controls that was ignoring mixSeconds#220
Open
sysebert wants to merge 5 commits into2d-inc:stablefrom
Open
🐛 - Fixed a bug in flare_controls that was ignoring mixSeconds#220sysebert wants to merge 5 commits into2d-inc:stablefrom
flare_controls that was ignoring mixSeconds#220sysebert wants to merge 5 commits into2d-inc:stablefrom
Conversation
…ssed into the `play()` method
… noticed that when it gets spammed with requests, there is a bit of a slowdown
…and out no matter if they have finished mixing already
Latest in branch
Merge the latest stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
play()method was referencing a private var_mixSecondsthat never had the ability to be set.