Skip to content

Support Adafruit_GFX::setRotation and 1/24 row scan pattern #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
terryspitz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support Adafruit_GFX::setRotation and 1/24 row scan pattern #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions PxMatrix.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,10 +717,30 @@ inline void PxMATRIX::fillMatrixBuffer(int16_t x, int16_t y, uint8_t r, uint8_t
}

if (_rotate){
uint16_t temp_x=x;
int16_t temp_x=x;
x=y;
y=_height-1-temp_x;
}

switch (rotation) {
case 1: {
int16_t temp_x=x;
x = WIDTH - 1 - y;
y = temp_x;
break;
}
case 2: {
x = WIDTH - 1 - x;
y = HEIGHT - 1 - y;
break;
}
case 3: {
int16_t temp_x=x;
x = y;
y = HEIGHT - 1 - temp_x;
break;
}
}

// Panels are naturally flipped
if (!_flip)
Expand Down Expand Up @@ -1027,17 +1047,17 @@ void PxMATRIX::begin(uint8_t row_pattern) {
digitalWrite(_B_PIN, LOW);
digitalWrite(_OE_PIN, HIGH);

if (_row_pattern >=8)
if (_row_pattern > 4)
{
pinMode(_C_PIN, OUTPUT);
digitalWrite(_C_PIN, LOW);
}
if (_row_pattern >=16)
if (_row_pattern > 8)
{
pinMode(_D_PIN, OUTPUT);
digitalWrite(_D_PIN, LOW);
}
if (_row_pattern >=32)
if (_row_pattern > 16)
{
pinMode(_E_PIN, OUTPUT);
digitalWrite(_E_PIN, LOW);
Expand Down Expand Up @@ -1067,7 +1087,7 @@ void PxMATRIX::set_mux(uint8_t value, bool random_access = false)
digitalWrite(_B_PIN,LOW);
if (_mux_delay_B) delayMicroseconds(_mux_delay_B);

if (_row_pattern>=8)
if (_row_pattern>4)
{

if (value & 0x04)
Expand All @@ -1078,7 +1098,7 @@ void PxMATRIX::set_mux(uint8_t value, bool random_access = false)
}


if (_row_pattern>=16)
if (_row_pattern>8)
{
if (value & 0x08)
digitalWrite(_D_PIN,HIGH);
Expand All @@ -1087,7 +1107,7 @@ void PxMATRIX::set_mux(uint8_t value, bool random_access = false)
if (_mux_delay_D) delayMicroseconds(_mux_delay_D);
}

if (_row_pattern>=32)
if (_row_pattern>16)
{
if (value & 0x10)
digitalWrite(_E_PIN,HIGH);
Expand Down