Remove Session config from Activate Admin #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francesmcmullin
force-pushed
the
uplift-redis-session
branch
from
ff73278 to
ef2cf36
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| def initialize | ||
| unless ActiveRecord::Base.connection.active? | ||
| unless ActiveRecord::Base.connection.active? || ActiveRecord::Base.connection_pool.active_connection? |
Check warning
Code scanning / Rubocop (reported by Codacy)
Limit lines to 80 characters. Warning
| session[:account_id] = account.id | ||
| flash[:notice] = "Logged in successfully." | ||
| redirect url(:home) | ||
| redirect params[:redir] or url(:home) |
Check warning
Code scanning / Rubocop (reported by Codacy)
Use &&/|| instead of and/or. Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are, broadly, two small changes here. If desired, I can separate them into 2 PRs, but it's more convenient if it's OK to combine them.
redirparam, and pay attention to it with real/production logins