Various bugfix (arguments, transparent images)#3
Various bugfix (arguments, transparent images)#3lrq3000 wants to merge 2 commits into43081j:masterfrom
Conversation
…sparent images + add comments + bump v0.5 Signed-off-by: Stephen L. <lrq3000@gmail.com>
Signed-off-by: Stephen L. <lrq3000@gmail.com>
|
This is going to be a real pain (sorry), but i just bumped the version and released a cleanup to master. Could you have a go at rebasing your branch onto it? After rebasing, could you then run p.s. it'll give you quite a few conflicts during rebase, again sorry for that but this really needed cleaning up. if you need any help, give me a shout and ill be around. |
|
Haha what a coincidence! I did not expect this repo to be updated since the last was 4 years ago! It doesn't seem like there are that many changes, I will try to have a look if I get some time :-) However note that my changes were made only to the standalone script, not the jquery one, so maybe these changes will have to be copied over there too (but I don't know enough about jquery to do that myself). |
|
no coincidence 🙈 saw your PR, then saw my code and couldn't resist cleaning up what past-james wrote :p so i am responsible for the horrid rebase you may have to do, but ill be here to help if needed 😶 dont worry about jquery, its the same file, it basically checks if jquery is defined (in a silly way, which we should probably change) and adds its self as an extension method. |
This PR fixes various issues:
valueparameter).This also adds code comments and update the readme and add a license to be detected by Github.