Remove invalid VEC conversion tests and cleanup package hierarchy#444
Merged
beckerjohannes merged 3 commits intodevelopfrom Feb 10, 2026
Merged
Conversation
Were basically accidentally added with commit 440e0b2.
DManstrator
added
Compatibility
DManstrator
changed the title
TobiasFehlmann
approved these changes
Feb 3, 2026
|
beckerjohannes
approved these changes
Feb 10, 2026
beckerjohannes
deleted the
cleanup/remove-invalid-vec-conversion-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Changes
Description
Was found while working on #443. There were tests which effectively did nothing or not what they should do (reading VEC 1.2.X with the VEC 1.2.X reader, thus having no conversion). Those tests have been removed without any replacement since there were already tests with a conversion to VEC 2.X.X. Also improved the package structure of those tests.