Improve MTG deck template visual layout #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced float-based layout with CSS Grid for better responsive behavior: - Cards now auto-fit into available screen width - Responsive card sizing using clamp() for different viewports - Mobile optimization: stacks overlap on narrow screens with hover to bring forward - Eliminated excessive margins when stacks have fewer than 4 cards - Maintains card stacking visualization with offset positioning This provides better scaling from mobile to desktop while preserving the visual representation of card quantities through stacked cards.
- Increased card size on mobile from 150-250px to 260px for better readability - Increased stack height to 280px to reduce overlap and improve clarity - Added 2rem spacing between card type sections - Added proper margin to section headers to prevent overlap with cards Cards are now larger and more readable on narrow screens, with clear separation between Lands, Creatures, Instants/Sorceries, etc.
Increased mobile stack height from 280px to 380px to properly contain cards with maximum offset (120px) plus card height (260px). Added overflow: visible to prevent any clipping of cards. This fixes the issue where cards were extending beyond the container border on narrow screens.
- Changed cards to width-based sizing (up to 340px or 90vw) instead of fixed height - Cards now maintain proper aspect ratio with height: auto - Added 1rem gap between stacks for better visual separation - Cards utilize more horizontal screen space on mobile devices
- Increased stack height to 500px to fully contain wider cards - Added overflow: hidden to stacks (visible on hover) to prevent card spillover - Increased grid margin-bottom to 3rem for better section separation - Added z-index and background to headers to ensure they stay above cards - Added extra margin and padding for proper spacing between sections Section headers now always appear clearly below the previous section's cards.
…ow hidden - Increased stack height from 500px to 600px to accommodate full card height - Changed overflow from hidden to visible to prevent bottom clipping - Cards now display fully without being cut off Headers remain protected by z-index and background styling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.