Fix 3D editor crashes/flashes when adding a new object or extension #8052
+311
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
4ian
commented
Dec 8, 2025
4ian
commented
- When adding a new object type, the hot reload could break if a previous hot reload was done without the script files (typically, when adding an object from an already used type)
- When adding a new object or anything needing a loading screen, the loading screen and the in-game editor were fighting for the rendering.
* When adding a new object type, the hot reload could break if a previous hot reload was done without the script files (typically, when adding an object from an already used type) * When adding a new object or anything needing a loading screen, the loading screen and the in-game editor were fighting for the rendering.
…the asset store) This was because: - The new object was the first of its type, and the second preview (related to the added object, after the first one related to the added resource) was wrongly not launched because of a stale state being read. - On the web-app, the first hot reload was longer to launch than the second preview, and so the second hot reload was not launched. Now, it is queued properly. - When an asset pack was installed, new object type was not recognized
4ian
force-pushed
the
fix/reload-crashs-and-flashes
branch
from
814bb40 to
59d4ecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.