[BugFix] Small Clean ups to get local dev version working #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Devs,
I have been tasked with implementing connected systems and came across your repo. However, it seems that your readme and some of the code is a little out of date and did not work out-of-the-box.
Figured I would make a merge request of the small changes I did to get the project from zero to hero.
Disclaimer: I don't really do Python, so I may have misunderstood some of the python code changes. Also, the readme info may be unnecessary to python devs, but it helped start the project from scratch so figured it may be worth including.
...
The main issues I ran into
secrets.token_hex(32)nottest. So I added them to the.env.sample. I also turned off basic by default in the.env.sampleanyways as that just made quick dev testing easier. But I can easily change it back to "true" if basic should be turned on by defaulttypeOf["rel"]fails if the typeOf object does not have a rel; which the default system does have. I could have added it to the system post json request but I think the intention was make it optional, so I turned into a safe get fielditem["deployment@link"]fails if deployment@link is not set. This time I could get away withgetto safely get the field value. Again, I assumed the intention was this should be optional.