feat/improving fsm scaffolding #613
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
8ball030
commented
Mar 14, 2025
8ball030
commented
- feat:added-further-param-types
- fix:ensured-correct-path-for-install
- feat:adev_improvements
8ball030
commented
Mar 14, 2025
|
|
||
|
|
||
| # We remove the __pycache__ directories to avoid conflicts | ||
| result = (result == 0 or result == pytest.ExitCode.NO_TESTS_COLLECTED) |
Owner
Author
There was a problem hiding this comment.
This means we dont need tests in a component for it to pass the tests.
I am in a 2 minds about this;
A) it definitely does make it easier,
But the thing about tasking the path of least resistance is that we SHOULD have tests for everything we generate.
Karrenbelt
reviewed
Mar 14, 2025
Comment on lines
+4
to
+5
| # Copyright 2023 {{author}} | ||
| # Copyright 2023 valory-xyz |
Collaborator
There was a problem hiding this comment.
wrong year, make it dynamic. Remove valory-xyz as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.