-
Notifications
You must be signed in to change notification settings - Fork 1
Build CI #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build CI #31
Conversation
a437f9d to
8e9624e
Compare
|
I think the OpenMPI build is incompatible: This is the concretisation of the failed build: I guess set |
|
Sorry, which was that for @anton-seaice? access or no-access? Or both? |
|
This is for no-access, access will fail until we update the linking in the access3-share cmake |
Co-authored-by: Anton Steketee <79179784+anton-seaice@users.noreply.github.com>
|
Might add the compiler definitions to a data file once this is done. Also once this completes successfully, it should push a lot of these packages to the binary cache, so this should be as slow as it gets |
|
Err, at least the |
|
We need to add the mpi linking to the access3-share package - that's why the access3 ones are failing Why the standalone builds are failing is a mystery! That code is a bit of c code mixed in with the fortran, maybe that's related somehow? |
|
https://github.com/ACCESS-NRI/CICE/actions/runs/16612429581/job/46998060356?pr=31#step:13:1682 😌 this is what we wanna see |
|
Ok - ill park this until i update access3-share! Thanks for the progress so far @CodeGat :) |
|
No worries @anton-seaice, give me a shout if you need anything |
| @@ -0,0 +1,10 @@ | |||
| spack: | |||
| specs: | |||
| - access-cice @git.{{ ref }} ~access3 io_type=PIO %gcc@13.2.0 target=x86_64 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to use template variables for compiler versions to make it easier to keep them all sync. My preference would be to use the ones defined in the build-ci repo so they're consistent across the org.
Same for the others below. May as well use the target variable too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 672529f
|
@anton-seaice I suggest splitting out the bits that are currently crashing, merge the stuff that is working, and represents the current state, and make an issue and PR to fix the failing CI build. |
|
I've excluded the two failing manifests from the matrix build for now, see 0caddea @aidanheerdegen, @anton-seaice |
aidanheerdegen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question about the CMake build system changes.
Ok to merge if those are required, otherwise we should drop them for this PR.
Adding Moving |
Co-authored-by: Anton Steketee <79179784+anton-seaice@users.noreply.github.com>
|
Happy to merge @CodeGat - ill resolve the remaining issues with the access3-share workflow soon ! |
|
Cool. I was wondering, did you want to pin the version of |
|
|
|
Thanks for your help with this one, @anton-seaice |
* Add matrix-compatible build-ci * Add access3, no-access3 manifests * add MPI components fortran and linking * Change esmf to git.8.7.0 * Prepend v to esmf requirements * Add oneapi compiler to openmpi constraints * Split manifests down compiler lines, update max-parallel to 5 * Apply suggestions from code review Co-authored-by: Anton Steketee <79179784+anton-seaice@users.noreply.github.com> * Specify target explicitly so it caches better * Try setting FORTRANUNDERSCORE * Replace compiler, target with template vars * Exclude `[intel|oneapi]-access3.spack.yaml.j2` manifests from matrix pending fix * Apply suggestions from code review Co-authored-by: Anton Steketee <79179784+anton-seaice@users.noreply.github.com> --------- Co-authored-by: anton-seaice <anton.steketee@anu.edu.au> Co-authored-by: Anton Steketee <79179784+anton-seaice@users.noreply.github.com>
Closes #30
Background
This is a simple matrix implementation of
build-ciusingaccess3and non-access3manifests.The PR