Open
Conversation
blimlim
approved these changes
Mar 12, 2025
Collaborator
blimlim
left a comment
There was a problem hiding this comment.
Thanks @kieranricardo for putting this together, it looks really good to me! Just had a couple tiny suggestions, but otherwise happy to approve
| use med_internalstate_mod , only : mapconsf | ||
| use med_constants_mod , only : dbug_flag => med_constants_dbug_flag | ||
| use med_methods_mod , only : FB_GetFldPtr => med_methods_FB_GetFldPtr | ||
|
|
Collaborator
There was a problem hiding this comment.
I'm not 100% on this, but are the following needed for this subroutine:
use med_map_mod , only : med_map_field
use med_internalstate_mod , only : mapconsf
use med_constants_mod , only : dbug_flag => med_constants_dbug_flag
use med_methods_mod , only : FB_GetFldPtr => med_methods_FB_GetFldPtr
If they aren't needed, wondering if it's best to remove them just for clarity?
| character(len=*), parameter :: subname='(med_phases_post_atm_custom_access)' | ||
| character(len=CS) :: fld_names(4) | ||
| !--------------------------------------- | ||
|
|
Collaborator
There was a problem hiding this comment.
Possibly unnecessary, but wondering if we should add the logging messages at the start and end just in case debugging is needed:
if (dbug_flag > 20) then
call ESMF_LogWrite(subname//' called', ESMF_LOGMSG_INFO)
end if
...
if (dbug_flag > 20) then
call ESMF_LogWrite(subname//' done', ESMF_LOGMSG_INFO)
end if
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
accesscoupling mode, this PR scalesatm->icefluxes by1 / ice_fractioninmed_phases_post_atm, prior to re-mapping atm quantities to the ice grid (time travelling ice approach).For access-cm3 using parallel coupling, this reduces conservation errors by a factor of ~50, to approx ~0.01% (measured over one coupling period).
See also https://github.com/ACCESS-NRI/cm3-suite/pull/26 and https://github.com/ACCESS-NRI/cm3-um/pull/9.