Skip to content

Add MOM5 REPRO flags to preserve answers with MOM5 internal FMS#12

Merged
dougiesquire merged 1 commit intomom5from
mom5-preserve-anwers
May 13, 2025
Merged

Add MOM5 REPRO flags to preserve answers with MOM5 internal FMS#12
dougiesquire merged 1 commit intomom5from
mom5-preserve-anwers

Conversation

@dougiesquire
Copy link
Collaborator

Description
Without the changes in this PR, ACCESS models built with the "internal" FMS included in the MOM5 repo give different answers than ACCESS models using "external" FMS in this repo - see here. This PR adds the MOM5 REPRO compiler flags so that answers can be preserved when moving from internal to external FMS.

How Has This Been Tested?
I have successfully reproduced answers from released versions of ACCESS-OM2 using these changes (this change to the access-fms SPR is also needed if using Spack)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@harshula harshula requested a review from micaeljtoliveira May 8, 2025 13:50
@harshula
Copy link

harshula commented May 9, 2025

Hi @dougiesquire , In MOM5, -fp-model precise -fp-model source appears to be set only when variant restart_repro is true (default). Should we have a similar variant for FMS? Will someone want to run MOM5 with restart_repro set to false?

@dougiesquire
Copy link
Collaborator Author

Will someone want to run MOM5 with restart_repro set to false?

I don't think so. I removed the option from the MOM5 CMake build system and have the restart repro flags set always - see here.

@dougiesquire dougiesquire force-pushed the mom5-preserve-anwers branch from 4127a8f to c55a9c3 Compare May 11, 2025 23:18
@dougiesquire dougiesquire merged commit bf9b804 into mom5 May 13, 2025
0 of 4 checks passed
@dougiesquire dougiesquire deleted the mom5-preserve-anwers branch May 13, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants