Conversation
blimlim
commented
Aug 25, 2025
Collaborator
dougiesquire
left a comment
There was a problem hiding this comment.
Thanks @blimlim! Could you please add comments to the code noting that HLV has been changed and why
Author
Good idea! I've added some comments in 47288ff |
Collaborator
dougiesquire
left a comment
There was a problem hiding this comment.
Sorry, being unnecessarily persnickety
Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
dougiesquire
approved these changes
Aug 25, 2025
Collaborator
dougiesquire
left a comment
There was a problem hiding this comment.
Thanks @blimlim! Please "squash and merge"
Author
|
Thanks @dougiesquire! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the value for the latent heat of evaporation from 2.50e6 J/kg to 2.501e6 J/kg. This is done for consistency with the values used in UM and CICE in ESM1.6, and the change results in an improvement in the coupled model's water balance.
Closes #17
How Has This Been Tested?

This change has been tested in a 3 month run of ESM1.6. It results in no loss of water during the evaporation coupling:
Compared to a loss of ~6.3e6kg/s without the change:

Checklist:
make distcheckpasses