Skip to content

Set hlv consistent with ESM1.6 UM and CICE#18

Merged
blimlim merged 3 commits intomom5from
17-coupled_hlv
Aug 25, 2025
Merged

Set hlv consistent with ESM1.6 UM and CICE#18
blimlim merged 3 commits intomom5from
17-coupled_hlv

Conversation

@blimlim
Copy link

@blimlim blimlim commented Aug 25, 2025

Description
This pull request updates the value for the latent heat of evaporation from 2.50e6 J/kg to 2.501e6 J/kg. This is done for consistency with the values used in UM and CICE in ESM1.6, and the change results in an improvement in the coupled model's water balance.

Closes #17

How Has This Been Tested?
This change has been tested in a 3 month run of ESM1.6. It results in no loss of water during the evaporation coupling:
download-30

Compared to a loss of ~6.3e6kg/s without the change:
download-29

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@blimlim blimlim requested a review from dougiesquire August 25, 2025 02:20
Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blimlim! Could you please add comments to the code noting that HLV has been changed and why

@blimlim
Copy link
Author

blimlim commented Aug 25, 2025

Could you please add comments to the code noting that HLV has been changed and why

Good idea! I've added some comments in 47288ff

Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, being unnecessarily persnickety

Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blimlim! Please "squash and merge"

@blimlim blimlim merged commit bf5f05b into mom5 Aug 25, 2025
4 checks passed
@blimlim
Copy link
Author

blimlim commented Aug 25, 2025

Thanks @dougiesquire!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants