Skip to content

Flux coupling edits#8

Draft
kieranricardo wants to merge 21 commits intomainfrom
flux-coupling-edits
Draft

Flux coupling edits#8
kieranricardo wants to merge 21 commits intomainfrom
flux-coupling-edits

Conversation

@kieranricardo
Copy link

@kieranricardo kieranricardo commented Feb 3, 2026

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    This introduces changes when running icepack in calc_tsfc=.false. mode for coupling with fluxes supplied from an atmosphere model.

  • Developer(s):
    @kieranricardo @blimlim

  • Suggest PR reviewers from list in the column to the right.

  • Please copy the PR test results link or provide a summary of testing completed below.
    ENTER INFORMATION HERE

  • How much do the PR code changes differ from the unmodified code?

    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?

    • Yes
    • No
  • Does this PR add any new test cases?

    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)

    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

When calc_tsfc=.false. the conductive flux is now capped, and it is also reduced during temperature_changes if the thermo solve is struggling to converge. The excess flux is accounted for in the energy calculations.

Also, hs_min is made configurable. A larger value than the default is needed for numerical stability when run with calc_tsfc=.false..

@kieranricardo
Copy link
Author

kieranricardo commented Feb 3, 2026

hey @anton-seaice, can you give this a look over before I make a PR into the CICE-consortium icepack? 👀

Copy link
Collaborator

@anton-seaice anton-seaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look properly, but i think split this into two changes, one for hs_min and one for the cap_fluxes stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants