Draft
Conversation
…onductive flux limits to CM2
Co-authored-by: Kieran Ricardo <u5824685@anu.edu.au>
Author
|
hey @anton-seaice, can you give this a look over before I make a PR into the CICE-consortium icepack? 👀 |
anton-seaice
reviewed
Feb 3, 2026
Collaborator
anton-seaice
left a comment
There was a problem hiding this comment.
I will look properly, but i think split this into two changes, one for hs_min and one for the cap_fluxes stuff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Short (1 sentence) summary of your PR:
This introduces changes when running icepack in
calc_tsfc=.false.mode for coupling with fluxes supplied from an atmosphere model.Developer(s):
@kieranricardo @blimlim
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
ENTER INFORMATION HERE
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on CICE or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.
When
calc_tsfc=.false.the conductive flux is now capped, and it is also reduced duringtemperature_changesif the thermo solve is struggling to converge. The excess flux is accounted for in the energy calculations.Also,
hs_minis made configurable. A larger value than the default is needed for numerical stability when run withcalc_tsfc=.false..