-
Notifications
You must be signed in to change notification settings - Fork 1
Testing CI #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing CI #61
Conversation
f9a56a3 to
10a352d
Compare
75e148a to
6b4aad9
Compare
6b4aad9 to
a9a260f
Compare
a9a260f to
c8fc8d0
Compare
c8fc8d0 to
afd6afc
Compare
fd4d217 to
4c726bb
Compare
72509f6 to
de577bd
Compare
de577bd to
270b740
Compare
I like this idea and I think the suggestions raised in the post are very useful! |
a64a261 to
0cbbb5e
Compare
0cbbb5e to
2d61a58
Compare
jo-basevi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added changes look good to me
… the running script fails or is interrupted, but not if the tests fail.
…rectory get removed in all cases when the script exits
…uild' needed job is skipped
f940332 to
a7da2b7
Compare
jo-basevi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @atteggiani, looks good to me! Just a minor style comment but I think it'll work
jo-basevi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
|
Thank you @jo-basevi and @CodeGat! |
Fixes #56
Overview
Added integration tests to CI workflow.
The added jobs do the following:
micromambaenvironment using env_dev.ymlreplace_landsurfacein the environment (usingmicromamba run ...for simplicity)micromamba run ...for simplicity)rm -rf ..., but the path of the temporary directory should be well defined and I can't see a better way to avoid it. Happy to discuss alternative solutions though.HOST,HOST_DATA,SSH_KEYandUSERsecrets, as well as theMICROMAMBA_EXEvariable have been set for theGadiGitHub environment.