Merged
Conversation
atteggiani
requested changes
Mar 6, 2025
Collaborator
atteggiani
left a comment
atteggiani
left a comment
There was a problem hiding this comment.
Thank you @leoberhelman for working on this.
The structure looks good and the "TO BE ADDED" parts can be dealt with in the future.
Apart from the specific suggestions, as I mentioned in some comments, it might be useful to add some more detailed description and examples within each of the parsers.
Contributor
Author
|
I added the usage to the descriptions of the parsers, and now it can be accessed with --help. I also added a list of required software to include mule. |
atteggiani
force-pushed
the
lindsey/Readme
branch
from
77b1a00 to
eacb768
Compare
Update README.md Seperated the usage case Update README.md Update README.md Add the usage for the change_dump_date Update README.md Update README.md Co-authored-by: Davide Marchegiani <davide.marchegiani@gmail.com> Update README.md Co-authored-by: Davide Marchegiani <davide.marchegiani@gmail.com> Update README.md Co-authored-by: Davide Marchegiani <davide.marchegiani@gmail.com> Update README.md Co-authored-by: Davide Marchegiani <davide.marchegiani@gmail.com> Update README.md Co-authored-by: Davide Marchegiani <davide.marchegiani@gmail.com> Update README.md Co-authored-by: Davide Marchegiani <davide.marchegiani@gmail.com> Update README.md Co-authored-by: Davide Marchegiani <davide.marchegiani@gmail.com>
Update README.md
added the help functions
Added the --help to the fields subset Update um_fields_subset.py Added the usage to the description
added a usage to the --help
atteggiani
force-pushed
the
lindsey/Readme
branch
from
eacb768 to
6ce9c2e
Compare
atteggiani
approved these changes
Mar 13, 2025
Collaborator
atteggiani
left a comment
atteggiani
left a comment
There was a problem hiding this comment.
Thank you @leoberhelman
I rebased to main and made a few adjustments.
Good to be merged!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request handles the read me and the --help option with the specific instructions for singular functions