fix: clear custom API key on wallet disconnect and improve vault crea…#33
Merged
JosueBrenes merged 1 commit intomainfrom Jan 13, 2026
Merged
fix: clear custom API key on wallet disconnect and improve vault crea…#33JosueBrenes merged 1 commit intomainfrom
JosueBrenes merged 1 commit intomainfrom
Conversation
…tion button logic - Added a useEffect to clear the custom API key and reset validation states when the wallet address changes or disconnects. - Updated the vault creation button's disabled state logic to ensure it only requires a valid API key or validated custom API key for enabling the button.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on improving error handling and user experience in API key validation and vault creation workflows, along with some minor code cleanups and dependency adjustments. The most significant changes are related to how API key validation errors are handled, ensuring proper state resets when the wallet changes, and refining the logic for enabling the "Create Vault" button.
Error Handling and Validation Improvements:
DynamicIssueForm,VaultAuthorize, andVaultDashboardto avoid unused variable warnings and simplify error handling. [1] [2] [3]handleCreateVaultfunction, relying instead on button state for validation.State Management Enhancements:
useEffectinVaultDashboardto clearcustomApiKey, validation error, and validation state when the wallet disconnects or changes, preventing stale or invalid state when switching wallets.Code Cleanup and Dependency Updates:
usePublicApiKey.tsandwallet.provider.tsxfor cleaner code and to prevent potential dead code issues. [1] [2]network-switch-modal.tsx.