Consolidate operation-getting methods and return SowingAndPlanting for Variety products again #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r Variety products again
| { | ||
| case CategoryEnum.Variety: | ||
| // It's technically an error to log Harvesting as a variety product, | ||
| // but this was observed by Ag Leader in a CNH Pro1200 file in August 2025 |
Contributor
There was a problem hiding this comment.
The issue is due to Mappers/Manufacturers/CNH.cs @ 290. It is more of framework limitation than an error since Category lacks an enumeration item for Harvested Commodity. Arguably the "right" fix would be for us to add that to the framework and then make these changes, but the conditional you have here will probably cover us in all cases. The other possibility is to determine the harvested product by using reflection on the type. I'm fine with this going out like this for now, however.
Contributor
|
No objection from me. @kelly-nelson Does this need Doug to weigh in? |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates GetOperationTypeFromProductCategory and OverrideOperationTypeFromWorkingDatas into a single method, GetOperationType. This allows future mixing of product type and device operation type logic to achieve the best possible guess at operation type.
It also mostly restores a bit of functionality I removed in #256. Prior to that PR, Variety crops always resulted in a SowingAndPlanting operation type. Since that PR, Variety crops have fallen through to later logic. I restored the Variety logic with an exception for when the device operation type is Harvest (the reason for #256).