Skip to content

Fix a casting bug in GetNumberOfInstalledSections #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adv12 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix a casting bug in GetNumberOfInstalledSections #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ISOv4Plugin/Mappers/LoggedDataMappers/Import/CondensedWorkStateMeterCreator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ public List<ISOEnumeratedMeter> CreateMeters(IEnumerable<ISOSpatialRow> spatialR

public EnumeratedValue GetValueForMeter(SpatialValue value, ISOEnumeratedMeter meter)// EnumeratedWorkingData meter)
{
var sectionValue = GetSectionValue((uint)(int)value.Value, meter.SectionIndex); //Mac arm processors fail to correctly decode the value without the double (uint)(int) cast
var sectionValue = GetSectionValue((uint)(int)value.Value, meter.SectionIndex); //Mac arm processors fail to correctly decode the value without the double (uint)(int) cast. Same behavior seen on .NET 10 for Windows. See https://stackoverflow.com/questions/79762063/different-result-by-cast-negative-double-to-uint-with-net-framework-4-7-2-and
var enumerationMember = SectionValueToEnumerationMember[(int)sectionValue];

return new EnumeratedValue
Expand All @@ -148,7 +148,7 @@ public EnumeratedValue GetValueForMeter(SpatialValue value, ISOEnumeratedMeter m

private int GetNumberOfInstalledSections(SpatialValue spatialValue)
{
var value = (uint)spatialValue.Value;
var value = (uint)(int)spatialValue.Value; //Mac arm processors fail to correctly decode the value without the double (uint)(int) cast. Same behavior seen on .NET 10 for Windows. See https://stackoverflow.com/questions/79762063/different-result-by-cast-negative-double-to-uint-with-net-framework-4-7-2-and
const uint notInstalledValue = 0x03;

for (int i = 1; i < 17; i++)
Expand Down
Loading