Skip to content

do not store on on real DOM, may cause memory problems #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johan-gorter merged 1 commit into from
Jan 20, 2026
Merged

do not store on on real DOM, may cause memory problems #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 18 additions & 16 deletions src/projection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ let nodeToRemove = (vNode: VNode) => {
};

const vnodeOnlyProps = [
"on",
"afterCreate",
"afterUpdate",
"afterRemoved",
Expand Down Expand Up @@ -206,22 +207,6 @@ let setProperties = (
projectionOptions.styleApplyer!(<HTMLElement>domNode, styleName, styleValue);
}
}
} else if (propName === "on" && propValue) {
// object with string keys and function values
for (let [key, handler] of Object.entries(properties.on!)) {
let listener: EventHandler | undefined =
typeof handler === "function" ? handler : handler.listener;
if (eventHandlerInterceptor) {
listener = eventHandlerInterceptor(key, listener, domNode, properties);
}
if (listener) {
domNode.addEventListener(
key,
listener,
typeof handler === "function" ? undefined : handler.options
);
}
}
} else if (propName !== "key" && propValue !== null && propValue !== undefined) {
let type = typeof propValue;
if (type === "function") {
Expand All @@ -246,6 +231,23 @@ let setProperties = (
}
}
}
if (properties.on) {
// object with string keys and function values
for (let [key, handler] of Object.entries(properties.on)) {
let listener: EventHandler | undefined =
typeof handler === "function" ? handler : handler.listener;
if (eventHandlerInterceptor) {
listener = eventHandlerInterceptor(key, listener, domNode, properties);
}
if (listener) {
domNode.addEventListener(
key,
listener,
typeof handler === "function" ? undefined : handler.options
);
}
}
}
};

let addChildren = (
Expand Down
Loading