chore: revert to upstream numpyencoder #1185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix I submitted [upstream](hmallen/numpyencoder#8) to detect the Numpy version being used and handle type deprecation whilst providing backwards compatibility has now been merged. We can therefore revert to using upstream PyPI released version of `numpyencoder` and remove the use of the forked [AFM-SPM-numpyencoder](https://github.com/AFM-SPM/numpyencoder) version where the same fix had been applied. This in turn means that releases to PyPI will work again (as you can't release to PyPI when you have dependencies that come from Git repos).
`DeprecationWarning` warning with `pillow==11.3.0` was causing errors, not sure why deprecation should cause errors they shouldn't stop things running?!?!?!
ns-rse
force-pushed
the
ns-rse/numpyencoder-update
branch
from
38038e9 to
09c7e2b
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix I submitted upstream to detect the Numpy version being used and handle type deprecation whilst providing backwards compatibility has now been merged.
We can therefore revert to using upstream PyPI released version of
numpyencoderand remove the use of the forked AFM-SPM-numpyencoder version where the same fix had been applied.This in turn means that releases to PyPI will work again (as you can't release to PyPI when you have dependencies that come from Git repos).
Documentation has been updated and builds. Remember to update as required...docs/configuration.mddocs/usage.mddocs/data_dictionary.mddocs/advanced.mdand new pages it should link to.New functions/methods have typehints and docstrings.New functions/methods have tests which check the intended behaviour is correct.