Skip to content

Fix two issues that blocks training loop with continuous checkpoint enabled. #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix two issues that blocks training loop with continuous checkpoint enabled. #2854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/MaxText/checkpointing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from absl import flags
from etils import epath
from flax.training import train_state
import datetime
import jax
from MaxText import exceptions
from MaxText import max_logging
Expand Down Expand Up @@ -50,6 +51,7 @@
PersistentCheckpointOptions = emergency_checkpoint_manager.PersistentCheckpointOptions
EmergencyReplicatorCheckpointManager = emergency_replicator_checkpoint_manager.ReplicatorCheckpointManager

ASYNC_SAVE_TIMEOUT = datetime.timedelta(minutes=60)

class GrainCheckpointHandler(PyGrainCheckpointHandler, ocp.CheckpointHandler):
"""A CheckpointHandler that allows specifying process_index and process_count."""
Expand Down Expand Up @@ -230,6 +232,11 @@ def create_orbax_checkpoint_manager(
preservation_policy = preservation_policy_lib.LatestN(
max_num_checkpoints_to_keep
)
async_options = None
if enable_continuous_checkpointing:
async_options = ocp.AsyncOptions(
timeout_secs=int(ASYNC_SAVE_TIMEOUT.total_seconds()),
)
manager = CheckpointManager(
p,
item_names=item_names,
Expand All @@ -239,7 +246,8 @@ def create_orbax_checkpoint_manager(
enable_async_checkpointing=use_async,
save_decision_policy=save_decision_policy,
preservation_policy=preservation_policy,
),
async_options=async_options,
),
logger=orbax_logger,
)

Expand Down Expand Up @@ -711,7 +719,7 @@ def save_checkpoint(checkpoint_manager, step, state, config=None, data_iterator=
if config and config.enable_checkpointing:
if (
force
or (step % config.checkpoint_period == 0)
or (step % config.checkpoint_period == 0 and not config.enable_continuous_checkpointing)
or (config.enable_emergency_checkpoint and step % config.local_checkpoint_period == 0)
):
blocking_until_ready_start = time.time()
Expand Down
Loading