Skip to content

Conversation

@RissyRan
Copy link
Collaborator

Description

Small updates on MoE configuration

Tests

Manual check

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@github-actions
Copy link

🤖 Hi @RissyRan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This pull request introduces minor but valuable updates to the MoE configuration documentation. The changes enhance clarity and provide additional context for several parameters, improving the overall readability and usefulness of the documentation.

🔍 General Feedback

  • The updates provide better guidance on when to use specific MoE configuration options.
  • The explanations for use_custom_sort_vjp and mlp_bias are particularly helpful for understanding their purpose and benefits.

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants