-
Notifications
You must be signed in to change notification settings - Fork 443
Include test_assets from GCS in tpu/gpu dockerfiles #2898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| MODE=${{ inputs.build_mode }} | ||
| JAX_VERSION=NONE | ||
| LIBTPU_GCS_PATH=NONE | ||
| INCLUDE_TEST_ASSETS=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also apply this to nightly image? maxtext_jax_nightly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems both "maxtext_jax_nightly" and "maxtext_jax_stable" are using this yml
maxtext/.github/workflows/UploadDockerImages.yml
Lines 65 to 73 in 5595c85
| - device: tpu | |
| build_mode: stable | |
| image_name: maxtext_jax_stable | |
| dockerfile: ./dependencies/dockerfiles/maxtext_dependencies.Dockerfile | |
| - device: tpu | |
| build_mode: nightly | |
| image_name: maxtext_jax_nightly | |
| dockerfile: ./dependencies/dockerfiles/maxtext_dependencies.Dockerfile | |
| uses: ./.github/workflows/build_and_push_docker_image.yml |
where include_test_assests=true and base is "maxtext_jax_stable" from a certain date
maxtext/.github/workflows/build_and_push_docker_image.yml
Lines 117 to 118 in 5595c85
| INCLUDE_TEST_ASSETS=true | |
| BASEIMAGE=gcr.io/tpu-prod-env-multipod/maxtext_jax_stable:${{ inputs.image_date }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's right Shuning.
shuningjin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick fix!
Description
test_assetsfrom GCS in TPU/GPU docker images build nightlyFIXES: b/471848644
Tests
https://github.com/AI-Hypercomputer/maxtext/actions/runs/20583769072/job/59116469871
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.