Skip to content

Conversation

@SurbhiJainUSC
Copy link
Collaborator

Description

  • Include test_assets from GCS in TPU/GPU docker images build nightly

FIXES: b/471848644

Tests

https://github.com/AI-Hypercomputer/maxtext/actions/runs/20583769072/job/59116469871

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

MODE=${{ inputs.build_mode }}
JAX_VERSION=NONE
LIBTPU_GCS_PATH=NONE
INCLUDE_TEST_ASSETS=true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also apply this to nightly image? maxtext_jax_nightly

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems both "maxtext_jax_nightly" and "maxtext_jax_stable" are using this yml

- device: tpu
build_mode: stable
image_name: maxtext_jax_stable
dockerfile: ./dependencies/dockerfiles/maxtext_dependencies.Dockerfile
- device: tpu
build_mode: nightly
image_name: maxtext_jax_nightly
dockerfile: ./dependencies/dockerfiles/maxtext_dependencies.Dockerfile
uses: ./.github/workflows/build_and_push_docker_image.yml

where include_test_assests=true and base is "maxtext_jax_stable" from a certain date

INCLUDE_TEST_ASSETS=true
BASEIMAGE=gcr.io/tpu-prod-env-multipod/maxtext_jax_stable:${{ inputs.image_date }}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right Shuning.

Copy link
Collaborator

@shuningjin shuningjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants