Fix apparent bugs to improve reproducibility #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old version of networkx will lead to error: ImportErrorImportError : ImportError: from fractions import gcdcannot import name 'gcd' from 'fractions'
Comment out the RL training flag in the function call.
To avoid Error: `python cython_compile.py build_ext --inplace`
|
It's worked for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request improves the overall reproducibility and stability of the codebase by fixing several issues and updating environment requirements. The main changes include:
Bug Fixes
• Corrected a typo in the view_selection function call in captioner.py.
• Commented out the unused use_rl_training argument in dataset construction to avoid runtime errors.
• Fixed a duplicated launch_distributed(args) call in main.py.
Dependency and Environment Updates
• Updated the networkx version in README.md to avoid deprecated imports and ensure compatibility with Python 3.9+.
• Added a NumPy version requirement (numpy==1.26.4) to prevent inconsistent behavior across Python environments.
Argument Parser Improvements
• Added a --local-rank argument to the parser to support distributed training launched by PyTorch’s distributed utilities.
Script Fixes
• Updated train.generalist.sh to use the correct dataset name (scenecold_dataset) and removed inconsistent arguments.
These fixes address multiple reproducibility issues that affected both training and dataset loading. The overall goal is to make the project easier to run out of the box.