Fix #28. Allow directives with the same name.#64
Open
couto wants to merge 1 commit intoANXS:masterfrom
Open
Conversation
Member
|
I've run into this problem as well. Will take a look at your PR but conceptually I think this looks fine to me :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's the first time that I use the Jinja2 template system, so I'm not really sure about the correctness of this fix.
I wanted to reuse multiple directives with the same name, much like specified in #28
e.g.:
However this doesn't work.
With this PR (that might need testing by someone with more experience than me) the following should work: