Skip to content
This repository was archived by the owner on Jun 14, 2023. It is now read-only.

Conversation

@romanleitner
Copy link

GeneralUtility::array_merge_recursive_overrule is a depreciated method of 6.2, has been moved to ArrayUtility::mergeRecursiveWithOverrule. Thats why your operator is wrong, should be ">".

GeneralUtility::array_merge_recursive_overrule is a depreciated method of 6.2, has been moved to ArrayUtility::mergeRecursiveWithOverrule. Thats why your operator is wrong, should be ">".
@tomasnorre
Copy link

@romanleitner

Looks like we don't need the if at all.
Both
\TYPO3\CMS\Core\Utility\GeneralUtility::explodeUrl2Array()
\TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule()

are also available in TYPO3 6.2, so looks like we can skip the if completely..

https://api.typo3.org/typo3cms/62/html/class_t_y_p_o3_1_1_c_m_s_1_1_core_1_1_utility_1_1_general_utility.html#a88a1c7c48f48b670dae9d4e8e464e3d8
https://api.typo3.org/typo3cms/62/html/class_t_y_p_o3_1_1_c_m_s_1_1_core_1_1_utility_1_1_array_utility.html#a2eb6d2191036aeb191ef9911c98686ca

Please correct me if I'm wrong.

@romanleitner
Copy link
Author

romanleitner commented Nov 9, 2017

Hi @tomasnorre ,

yes you are right.
Methods
\TYPO3\CMS\Core\Utility\GeneralUtility::explodeUrl2Array()
\TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule()
are available in both versions 6.2.x and 7.6.x., so we can remove the condition.

Its only about the method \TYPO3\CMS\Core\Utility\GeneralUtility::array_merge_recursive_overrule is not available anymore in v 7.6.x

lg
Roman

Removed condition to check T3 version, not needed because methods ArrayUtility::mergeRecursiveWithOverrule and GeneralUtility::explodeUrl2Array are available in both T3 versions 6.2.x and 7.6.x.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants