-
Notifications
You must be signed in to change notification settings - Fork 330
fixed #336 by adding input validation block #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughAdded input validation to the /get_boolq endpoint in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
backend/server.py (1)
79-79: Remove unnecessary blank line.Line 79 contains only whitespace within the
jsonifycall. Consider removing it for cleaner formatting.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
backend/server.py
🔇 Additional comments (1)
backend/server.py (1)
74-83: Apply consistent input validation across all question generation endpoints.The
/get_mcq,/get_shortq, and/get_problemsendpoints lack the input validation added to/get_boolq. All three should check for minimum text length before processing, especially/get_problemswhich calls all three question generators. Without validation, they may return generic or unrelated questions for missing or insufficient input.
fixes #336 by adding an input validation block
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.