Skip to content

Minor UI imporvements in signup page#134

Open
DeveloperAmrit wants to merge 1 commit intoAOSSIE-Org:mainfrom
DeveloperAmrit:fix-130-131-ui
Open

Minor UI imporvements in signup page#134
DeveloperAmrit wants to merge 1 commit intoAOSSIE-Org:mainfrom
DeveloperAmrit:fix-130-131-ui

Conversation

@DeveloperAmrit
Copy link

@DeveloperAmrit DeveloperAmrit commented Jan 17, 2026

Closes #130
Fixes #131

📝 Description

Hardcoded height was causing overflow issues in signup page, fixed that. Also, on signup page in create team and join team screen, some text was getting covered due to less spacing, fixed that.

🔧 Changes Made

  • Fixed teamID/team name label which was being covered on sign up page.
  • Used elements in signup page which will not cause overflow errors on any screen.

📷 Screenshots or Visual Changes (if applicable)

Before
image

After
image

🤝 Collaboration

Collaborated with: @username (optional)

✅ Checklist

  • [y ] I have read the contributing guidelines.
  • [y ] I have added tests that prove my fix is effective or that my feature works.
  • [y ] I have added necessary documentation (if applicable).
  • [ y] Any dependent changes have been merged and published in downstream modules.

Summary by CodeRabbit

  • Refactor
    • Restructured signup screen tab layout to dynamically render forms based on active tab selection, removing fixed-height constraints for improved responsiveness.
    • Updated text field hint text behavior to enhance consistency across input fields.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 17, 2026

📝 Walkthrough

Walkthrough

This PR resolves layout overflow and hint text display issues on the signup screen. It refactors the signup form from a fixed-height TabBarView to dynamic conditional rendering based on selected tab, and corrects the CustomTextField to strictly separate hint text from label rendering.

Changes

Cohort / File(s) Summary
Signup Screen Layout Refactoring
lib/screens/auth/signup_screen.dart
Extracted form builders into two private helper methods (_buildJoinTeamForm() and _buildCreateTeamForm()) and replaced fixed-height TabBarView with dynamic form selection based on _tabController.index. Added TabBar onTap handler to trigger rebuilds on tab switch, eliminating overflow constraints from the 350px SizedBox container. Existing validation and submission handlers preserved.
CustomTextField Hint Text Fix
lib/widgets/custom_widgets.dart
Changed effectiveHintText logic from fallback pattern label ?? hintText to always use hintText. This prevents label text from being used as placeholder and ensures proper separation between floating label and hint text rendering.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 The forms now dance with graceful flow,
No fixed walls to steal the show!
The hints and labels, clear and bright,
Each in their place, perfectly right!
A scrolling canvas, overflow-free— hop!

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Minor UI imporvements in signup page' is related to the changeset but contains a typo ('imporvements' instead of 'improvements') and is somewhat vague, using generic phrasing that doesn't convey the specific changes (removing fixed height and fixing label overlap). Correct the typo and make the title more specific, e.g., 'Fix signup page overflow and CustomTextField label overlap' to clearly indicate the main problems being addressed.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR successfully addresses both linked issues: removes the fixed-height SizedBox from TabBarView (issue #130) and fixes the CustomTextField hintText logic to prevent label overlap (issue #131).
Out of Scope Changes check ✅ Passed All changes are directly scoped to addressing issues #130 and #131; no unrelated modifications were introduced to the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: "Team ID" Label Getting Covered in signup page BUG: "RenderFlex overflowed by 14 pixels" error on signup page

1 participant