Skip to content

améliorations #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kgersen wants to merge 3 commits into
base: master
Choose a base branch
from
Open

améliorations #4

kgersen wants to merge 3 commits into from

Conversation

@kgersen
Copy link

@kgersen kgersen commented Jan 30, 2019

  • gitignore
  • separation des données du code (list des serveurs = stdin ou fichier argument)
  • test version speedtest-cli

@kgersen
- gitignore
1f31051 
- separation des données du code (list des serveurs = stdin ou fichier argument)
- test version speedtst-cli
@kgersen
fix read from pipe
522e12e 
fix headers
@kgersen kgersen closed this Jan 30, 2019
@kgersen
Copy link
Author

kgersen commented Jan 30, 2019

petit bug. j'en poste un autre.

@kgersen kgersen reopened this Jan 30, 2019
@Harvester57
Copy link
Contributor

Harvester57 commented Jan 30, 2019

Pensez à passer Shellcheck et Bashate sur le code, il y a quelques endroits où les variables sont mal quotées, ce qui pourrait causer des comportement surprenant en manipulant des chaînes de caractères venant d'un fichier externe :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kgersen @Harvester57