-
Notifications
You must be signed in to change notification settings - Fork 5
Added support for Meala remote log database #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dakejahl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Can you update the PR description to include a link to the docs/website for Meala? What level of testing has been done? Can you update the README and add a table to indicate the supported backends?
| #include <vector> | ||
| #include <sqlite3.h> | ||
| #include <mavsdk/plugins/log_files/log_files.h> | ||
| #include <optional> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary?
| MealaCredentials _creds; | ||
| std::string _session_cookie; | ||
| bool _logged_in = false; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put this class declaration and MealaCredentials struct in a separate header
| #include <functional> | ||
| #define CPPHTTPLIB_OPENSSL_SUPPORT | ||
| #include <httplib.h> | ||
| #include <vector> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary?
| .public_logs = true, // Public required true for searching using Web UI | ||
| .upload_service = UploadService::FlightReview, // Local server is always FlightReview, | ||
| .credentials_file = "" // FlightReview does not need credentials | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #include <future> | ||
| #include <regex> | ||
| #include <fstream> | ||
| #include "ServerInterface.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #include "ServerInterface.hpp" |
already in the hpp
Added support to choose FlightReview or Meala as a remote log database.
FlightReview is the default remote upload service. To use Meala, the following configuration settings are used:
Upload service = 1
Remote server = http://www.apisdynamics.ca
Credentials file = /home/jetson//.local/share/logloader/meala_creds.cert (or any other prefered location)
You need to sign up for Meala and download a credential certificate to use.