Skip to content

Conversation

@phinchey
Copy link

Added support to choose FlightReview or Meala as a remote log database.

FlightReview is the default remote upload service. To use Meala, the following configuration settings are used:

Upload service = 1
Remote server = http://www.apisdynamics.ca
Credentials file = /home/jetson//.local/share/logloader/meala_creds.cert (or any other prefered location)

You need to sign up for Meala and download a credential certificate to use.

Copy link
Collaborator

@dakejahl dakejahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Can you update the PR description to include a link to the docs/website for Meala? What level of testing has been done? Can you update the README and add a table to indicate the supported backends?

#include <vector>
#include <sqlite3.h>
#include <mavsdk/plugins/log_files/log_files.h>
#include <optional>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary?

MealaCredentials _creds;
std::string _session_cookie;
bool _logged_in = false;
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this class declaration and MealaCredentials struct in a separate header

#include <functional>
#define CPPHTTPLIB_OPENSSL_SUPPORT
#include <httplib.h>
#include <vector>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary?

.public_logs = true, // Public required true for searching using Web UI
.upload_service = UploadService::FlightReview, // Local server is always FlightReview,
.credentials_file = "" // FlightReview does not need credentials

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

#include <future>
#include <regex>
#include <fstream>
#include "ServerInterface.hpp"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include "ServerInterface.hpp"

already in the hpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants