Find middle characters for odd and even words.#141
Open
JoseTorrez wants to merge 1 commit intodevelopfrom
Open
Find middle characters for odd and even words.#141JoseTorrez wants to merge 1 commit intodevelopfrom
JoseTorrez wants to merge 1 commit intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #141 +/- ##
=============================================
+ Coverage 87.84% 87.93% +0.09%
- Complexity 456 459 +3
=============================================
Files 103 104 +1
Lines 987 995 +8
Branches 161 162 +1
=============================================
+ Hits 867 875 +8
Misses 106 106
Partials 14 14
Continue to review full report at Codecov.
|
carledriss
reviewed
Sep 11, 2017
| } else { | ||
| subWord = word.substring(half, half + 1); | ||
| } | ||
| return subWord; |
Contributor
There was a problem hiding this comment.
This may be refactored like this.
int half = word.length() / 2;
return word.length() % 2 == 0 ? word.substring(half - 1, half + 1) : word.substring(half, half + 1);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.