Skip to content

Suggestions for Chapter 05 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neuroevolutus wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Suggestions for Chapter 05 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8ebba2
Fix typo
neuroevolutus Apr 13, 2024
a9c81f4
Remove unnecessary key/value pairs from `chapter05/vpc.yaml`
neuroevolutus Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chapter05/firewall5.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Resources:
SecurityGroupProxy:
Type: 'AWS::EC2::SecurityGroup'
Properties:
GroupDescription: 'Allowing incoming HTTP and ICPM from anywhere.'
GroupDescription: 'Allowing incoming HTTP and ICMP from anywhere.'
VpcId: !Ref VPC
SecurityGroupIngress:
- Description: 'allowing inbound ICMP traffic'
Expand Down
3 changes: 0 additions & 3 deletions chapter05/vpc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,11 @@ Resources:
Type: 'AWS::EC2::VPC'
Properties:
CidrBlock: '10.0.0.0/16'
EnableDnsHostnames: 'true'
Tags:
- Key: Name
Value: 'AWS in Action: chapter 5 (VPC)'
InternetGateway:
Type: 'AWS::EC2::InternetGateway'
Properties: {}
VPCGatewayAttachment:
Type: 'AWS::EC2::VPCGatewayAttachment'
Properties:
Expand All @@ -77,7 +75,6 @@ Resources:
Properties:
AvailabilityZone: !Select [0, !GetAZs '']
CidrBlock: '10.0.0.0/24'
MapPublicIpOnLaunch: true
VpcId: !Ref VPC
Tags:
- Key: Name
Expand Down