Add SCM actions to standard diff editor for consistent accept/discard experience #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… experience This change adds accept/discard buttons to the standard diff editor when displaying SCM resources, ensuring consistency with the QuickDiffWidget experience. Changes: - Modified TextDiffEditor to detect SCM diffs and display SCM context menu actions - Added toolbar container and styling for SCM actions - Integrated MenuId.SCMChangeContext menu to provide accept/discard functionality - Added proper context key setup and lifecycle management This fixes the issue where accept/discard buttons were only available when opening diffs from the editor (diff icon) but not when opening from the changes view. Closes the gap between the two diff viewing experiences by ensuring SCM actions are available in both contexts. Co-authored-by: biobootloader <128252497+biobootloader@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds accept/discard buttons to the standard diff editor when displaying SCM resources, ensuring consistency with the QuickDiffWidget experience.
Changes:
This fixes the issue where accept/discard buttons were only available when opening diffs from the editor (diff icon) but not when opening from the changes view.
Closes the gap between the two diff viewing experiences by ensuring SCM actions are available in both contexts.
🤖 See my steps and cost here ✨