V2 Withdraw To Endpoint #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Kayanski seems like wrong base? |
Buckram123
reviewed
Apr 15, 2024
| })?; | ||
| } | ||
|
|
||
| deps.api.debug(&format!("{:?}", withdraw_msgs)); |
Contributor
There was a problem hiding this comment.
about gas situation, noticed you have a lot of debugs. Want to mention that it will still eat gas for converting variable to debug string, and to allocate formatted string even if it does not get printed. Not really sure how much it is actually, but just to keep in mind before next gas measurements
Contributor
Author
There was a problem hiding this comment.
Oh yes you are right ! This is very low though compared to what the app is actually eating !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at adding a Withdraw To endpoint to withdraw everything from the position to a single asset