Skip to content

Fix logging in MovieFFmpeg with multiple threads #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cedrik-fuoco-adsk merged 3 commits into from
Jan 9, 2026
Merged

Fix logging in MovieFFmpeg with multiple threads #1045

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
853c201
fix logs in multithread env
cedrik-fuoco-adsk Dec 17, 2025
bf0a501
pre-commit
cedrik-fuoco-adsk Jan 9, 2026
11d0b56
Merge branch 'main' into fix-movieffmpeg-log-threading-issue
cedrik-fuoco-adsk Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions src/lib/image/MovieFFMpeg/MovieFFMpeg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include <set>
#include <limits>
#include <cmath>
#include <mutex>
#include <boost/filesystem.hpp>
#include <boost/filesystem/operations.hpp>
#include <boost/thread/mutex.hpp>
Expand Down Expand Up @@ -1420,14 +1421,14 @@ namespace TwkMovie
{
if (!videoToolboxInit(avCodec, avCodecContext, hardwareContext))
{
static bool hasDisplayedError = false;
if (!hasDisplayedError)
{
std::cout << "WARNING: Hardware decoder is not available "
"or failed to intialize."
<< std::endl;
hasDisplayedError = true;
}
static std::once_flag warnOnce;
std::call_once(warnOnce,
[]()
{
std::cout << "WARNING: Hardware decoder is not available "
"or failed to intialize."
<< std::endl;
});
}
}
#endif
Expand Down Expand Up @@ -3785,14 +3786,15 @@ namespace TwkMovie
const AVPixFmtDescriptor* desc = av_pix_fmt_desc_get(nativeFormat);
if (!desc && nativeFormat == AV_PIX_FMT_NONE)
{
static bool warned = false;
if (!warned)
{
std::cout << "WARNING: FFmpeg detected pixel format "
"AV_PIX_FMT_NONE for frames in "
<< m_filename << ". Using fallback pixel format: " << av_get_pix_fmt_name(m_pxlFormatOnOpen) << std::endl;
warned = true;
}
static std::once_flag warnOnce;
std::call_once(warnOnce,
[this]()
{
std::cout << "WARNING: FFmpeg detected pixel format "
"AV_PIX_FMT_NONE for frames in "
<< m_filename << ". Using fallback pixel format: " << av_get_pix_fmt_name(m_pxlFormatOnOpen)
<< std::endl;
});
// Use the pixel format detected when the file was opened as a
// fallback. Assumes that m_pxlFormatOnOpen is set because the file
// was opened.
Expand Down
Loading