feature/2252 resolve Update Contact Data activities in Journeys #2420

yuliialikhyt · 2025-11-13T19:58:54Z

PR details

What changes did you make? (Give an overview)

Before

After

Added some changes to have the Data Extension field name resolved and add the Data Extension key to the journey instead of ObjectID.

closes [FEATURE] resolve Update Contact Data activities in Journeys #2252

Further details (optional)

...

Checklist

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
test scripts updated
Wiki updated (if applicable)

…of calls in tests to accomodate the change

…in-Journeys

github-actions · 2025-11-13T20:53:02Z

Coverage Report

Commit:14d2477
Base: develop@36e9bb6

Type	Base	This PR
Total Statements Coverage	70.66%	70.72% (+0.06%)
Total Branches Coverage	70.69%	70.7% (+0.01%)
Total Functions Coverage	83.44%	83.46% (+0.02%)
Total Lines Coverage	70.66%	70.72% (+0.06%)

Details (changed files):

File	Statements	Branches	Functions	Lines
lib/metadataTypes/DataExtensionField.js	83%	69.64%	90.9%	83%
lib/metadataTypes/Journey.js	68.84%	67.29%	96%	68.84%

…nction

lib/metadataTypes/definitions/Journey.definition.js

test/type.journey.test.js

lib/metadataTypes/definitions/Journey.definition.js

lib/metadataTypes/DataExtensionField.js

JoernBerkefeld · 2025-11-14T17:43:49Z

lib/metadataTypes/Journey.js

+                    const activityArguments = activity.arguments;
+                    for (
+                        let i = 0;
+                        i < activityArguments.activityData.updateContactFields.length;


You are assuming activityData and updateContactFields both exist here. Better to use ?. notation to make sure you dont trigger a js error

JoernBerkefeld · 2025-11-14T17:45:09Z

lib/metadataTypes/Journey.js

+                    ) {
+                        const contactField = activityArguments.activityData.updateContactFields[i];
+                        try {
+                            activityArguments.activityData.updateContactFields[


Use contactField var instead

lib/metadataTypes/Journey.js

…in-Journeys

JoernBerkefeld · 2025-11-20T14:32:31Z

lib/metadataTypes/Journey.js

+                            Util.logger.warn(' - Caching dependent Metadata: dataExtensionField');
+                            DataExtensionField.buObject = this.buObject;
+                            DataExtensionField.client = this.client;
+                            DataExtensionField.properties = this.properties;
+                            const dataExtensionFieldCache =
+                                await DataExtensionField.retrieveForCache();


Only re-cache if dataExtensionFields were not already cached please. where you placed it, this caching gets executed once for every journey in your retrieve

You can find an example of how i did that in Journey.deploy and Journey._postRetrieveTasksBulk:

I would recommend putting YOUR caching also into those 2 methods in a similar fashion (quick loop throuh journeys and the activities to check if the activity is even in the retrieve/deploy payload

just realized, there might be a slightly better option here:
u can use something like in DataExtension._retrieveFieldsForSingleDe() - that way it works nicely even on BUs with a extremely large amount of DEs / fields.

that said, this will mean quite a bit of extra work

I've added a function in the DataExtensionField like the one in the DataExtension retrieveFieldsForSingleDe. Let me know if that is ok 🙂

lib/metadataTypes/Journey.js

JoernBerkefeld · 2025-11-20T14:42:32Z

lib/metadataTypes/Journey.js

+                                dataExtensionFieldCache.metadata
+                            );
+                            try {
+                                contactField.field = cache.searchForField(


i get why you wanted to stick with "field" but the standard here would be r__dataExtensionField_name

JoernBerkefeld · 2025-11-20T14:44:25Z

lib/metadataTypes/Journey.js

+                        try {
+                            contactField.field = cache.searchForField(
+                                'dataExtensionField',
+                                `[${contactField.r__dataExtension_key}].[${contactField.field}]`,


Suggested change

`[${contactField.r__dataExtension_key}].[${contactField.field}]`,

`[${contactField.r__dataExtension_key}].[${contactField.r__dataExtensionField_name}]`,

lib/metadataTypes/definitions/Journey.definition.js

…https://github.com/Accenture/sfmc-devtools into feature/2252-resolve-update-contact-data-in-Journeys

Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>

…in-Journeys

JoernBerkefeld · 2025-11-28T22:11:39Z

lib/metadataTypes/Journey.js

+                                const fields = await DataExtensionField.retrieveFieldsForSingleDe(
+                                    contactField.r__dataExtension_key
+                                );
+                                cache.setMetadata('dataExtensionField', fields);


this wont work because now your cache for dataExtensionField is existing - but you only inserted fields for a single DE. Therefore, if you run this code for 2 updatecontactdata activities with a different dataExtension then the second one will not recache fields and hence fail to find any.

what could work is if you were to reset the dataExtensionField cache after running searchForField again - but only if you didnt find a dataExtensionField cache in the first place? bit hacky but should be most efficient that way.

let tempCachedFields = false; if (!cache.getCache().dataExtensionField) { tempCachedFields = true; ... } ... cache.searchForField(..); if(tempCachedFields) { cache.clearCache(this.buObject.mid, 'dataExtensionField'); }

Yeap, makes sense. I made the changes as suggested, in preDeploy and postRetrieve. Since the function retrieves all fields per DE, and one Update Contact activity is related to one DE only, cache is cleared once per UPDATECONTACTDATA activity. It will not re-cache once for every field, but once per every data extension / Update Contact activity.

JoernBerkefeld · 2025-11-28T22:23:46Z

lib/metadataTypes/Journey.js

+                            if (!cache.getCache().dataExtensionField) {
+                                DataExtensionField.buObject = this.buObject;
+                                DataExtensionField.client = this.client;
+                                DataExtensionField.properties = this.properties;
+                                const fields = await DataExtensionField.retrieveFieldsForSingleDe(
+                                    contactField.r__dataExtension_key
+                                );
+                                cache.setMetadata('dataExtensionField', fields);
+                            }
+                            contactField.r__dataExtensionField_name = cache.searchForField(
+                                'dataExtensionField',
+                                contactField.field,
+                                'ObjectID',
+                                'Name'
+                            );


see comment on resetting the cache in _preDeployTasks_activities and solve similarly here

JoernBerkefeld · 2025-11-28T22:29:08Z

lib/metadataTypes/DataExtensionField.js

-        const cachedDEs = cache.getCache().dataExtension;
-        if (cachedDEs) {
-            await DataExtension.attachFields(cachedDEs);
-        }
-        return;


please revert as you are not using this change. i believe whenever we want to cache fields, we ended up looking at them through dataExtensions alone and hence had the above logic in place

JoernBerkefeld · 2025-11-28T22:29:34Z

lib/metadataTypes/DataExtensionField.js


 // Assign definition to static attributes
 import MetadataTypeDefinitions from '../MetadataTypeDefinitions.js';
-import cache from '../util/cache.js';


please restore in favor of old version of retrieveForCache()

reverted retrieveForCache() and brought back the imports

…in-Journeys

yuliialikhyt added 5 commits November 7, 2025 00:11

#2252 resolve DE and fieldName

c9620e9

#2252 added retrieve of DataExtensionFields and increased the number …

a1e06dd

…of calls in tests to accomodate the change

#2252 added retrieve of DataExtensionField for caching

1726485

#2252 added retrieve of DataExtensionField for caching

5607072

#2252 removed dependecy from the dependencyGraph

7b7331e

github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Nov 13, 2025

yuliialikhyt and others added 3 commits November 13, 2025 21:02

Merge branch 'develop' into feature/2252-resolve-update-contact-data-…

dd36854

…in-Journeys

#2252 increased the number of calls in tests to accomodate the changes

13ee178

#2252 increased the number of calls in tests to accomodate the changes

011c3dc

#2252 updated the number of calls and updated the retrieveForCache fu…

62621d3

…nction

yuliialikhyt marked this pull request as ready for review November 13, 2025 22:28

yuliialikhyt self-assigned this Nov 14, 2025

yuliialikhyt requested a review from JoernBerkefeld November 14, 2025 10:47

JoernBerkefeld requested changes Nov 14, 2025

View reviewed changes

yuliialikhyt added 15 commits November 14, 2025 20:05

#2252 set custom fields to not updatable and not creatable

5d73891

#2252 updated code to use variable

d91552d

#2252 update dataGraph

75c5147

#2252 use contant

89b791a

#2252 tests

c493c65

#2252 tests

bad89ca

#2252 tests

22795f4

#2252 preDeploy logic

305f6ca

#2252 postRetrieve logic

8675239

#2252 caching

657fcf5

#2252 updated tests

4a6f5c2

#2252 updated tests

1d9e03a

#2252 updated tests

5df41a4

#2252 updated tests

075e5d0

#2252 added caching

16ea473

yuliialikhyt and others added 4 commits November 16, 2025 19:12

#2252 return empty array to avoid an error in case of null

9ad2a84

#2252 return empty array to avoid an error in case of null

b6b9136

#2252 safe operator

41e1124

Merge branch 'develop' into feature/2252-resolve-update-contact-data-…

4957506

…in-Journeys

JoernBerkefeld added the c/journey COMPONENT label Nov 17, 2025

JoernBerkefeld linked an issue Nov 17, 2025 that may be closed by this pull request

[FEATURE] resolve Update Contact Data activities in Journeys #2252

Open

1 task

JoernBerkefeld force-pushed the feature/2252-resolve-update-contact-data-in-Journeys branch from 8ab518e to 4957506 Compare November 17, 2025 17:15

Merge branch 'develop' into feature/2252-resolve-update-contact-data-…

7935d1c

…in-Journeys

JoernBerkefeld requested changes Nov 20, 2025

View reviewed changes

yuliialikhyt and others added 5 commits November 22, 2025 16:28

Merge branch 'feature/2252-resolve-update-contact-data-in-Journeys' of …

05488f1

…https://github.com/Accenture/sfmc-devtools into feature/2252-resolve-update-contact-data-in-Journeys

Update lib/metadataTypes/Journey.js

e9259f0

Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>

Update lib/metadataTypes/definitions/Journey.definition.js

e74faab

Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>

#2252 retrieve fields for one DE, updated tests

d3844c5

Merge branch 'develop' into feature/2252-resolve-update-contact-data-…

0c3f3ed

…in-Journeys

JoernBerkefeld added this to the 8.3.0 milestone Nov 24, 2025

yuliialikhyt added 3 commits November 24, 2025 22:42

#2252 some fixes

cf577ab

#2252 +1 API request for re-retrieve

8eb4ec6

#2252 caching

4c6fd50

JoernBerkefeld changed the title ~~feature/2252 resolve update contact data in journeys~~ feature/2252 resolve Update Contact Data activities in Journeys Nov 27, 2025

Merge branch 'develop' into feature/2252-resolve-update-contact-data-…

ed0824a

…in-Journeys

JoernBerkefeld requested changes Nov 28, 2025

View reviewed changes

yuliialikhyt and others added 5 commits December 2, 2025 20:14

#2252 revert change

4756beb

#2252 revert change

32cbd57

#2252 clear cache

80f897a

#2252 tests

2cc5c4f

Merge branch 'develop' into feature/2252-resolve-update-contact-data-…

14d2477

…in-Journeys

	`[${contactField.r__dataExtension_key}].[${contactField.field}]`,
	`[${contactField.r__dataExtension_key}].[${contactField.r__dataExtensionField_name}]`,

feature/2252 resolve Update Contact Data activities in Journeys #2420

Are you sure you want to change the base?

feature/2252 resolve Update Contact Data activities in Journeys #2420

Uh oh!

Conversation

yuliialikhyt commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR details

What changes did you make? (Give an overview)

Further details (optional)

Checklist

Uh oh!

github-actions bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoernBerkefeld Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yuliialikhyt commented Nov 13, 2025 •

edited

Loading

github-actions bot commented Nov 13, 2025 •

edited

Loading

JoernBerkefeld Nov 20, 2025 •

edited

Loading