Skip to content

Conversation

@JoernBerkefeld
Copy link
Contributor

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 8.3.0 milestone Nov 25, 2025
@JoernBerkefeld JoernBerkefeld self-assigned this Nov 25, 2025
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Nov 25, 2025
@github-actions
Copy link

github-actions bot commented Nov 25, 2025

Coverage Report

Commit:912ab27
Base: develop@34377da

Type Base This PR
Total Statements Coverage  70.7%  70.65%  (-0.05%)
Total Branches Coverage  70.67%  70.7%  (+0.03%)
Total Functions Coverage  83.42%  83.44%  (+0.02%)
Total Lines Coverage  70.7%  70.65%  (-0.05%)
Details (changed files):
File Statements Branches Functions Lines
lib/index.js  70.63%  64.98%  77.08%  70.63%
lib/util/devops.js  13.75%  100%  20%  13.75%

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the filter logic to support type-specific filters in addition to global filters. Previously, filters could only be applied uniformly across all metadata types. Now, filters can be scoped to specific metadata types or applied globally using a wildcard "*" key.

Key Changes

  • Introduced new BuildFilter and BuildFilterKeys type definitions to support type-specific filtering
  • Refactored filtering logic into a dedicated applyKeyFilters method for better code organization
  • Enhanced filter structure to allow both global ("*") and type-specific filter keys

Reviewed changes

Copilot reviewed 3 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
types/mcdev.d.js Added JSDoc type definitions for BuildFilter and BuildFilterKeys to support the new filtering structure
@types/types/mcdev.d.d.ts Generated TypeScript definitions for the new filter types
@types/types/mcdev.d.d.ts.map Updated source map for TypeScript definitions
lib/index.js Refactored filter logic into applyKeyFilters method with support for type-specific filters; updated method signatures to use BuildFilter type
lib/util/devops.js Removed intermediate filter variable and directly passed sourceMarketLists.filter to build method
@types/lib/index.d.ts Updated TypeScript method signatures to reflect BuildFilter parameter type
@types/lib/index.d.ts.map Updated source map for index TypeScript definitions
@types/lib/util/devops.d.ts Added BuildFilter type import
@types/lib/util/devops.d.ts.map Updated source map for devops TypeScript definitions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

JoernBerkefeld and others added 2 commits November 25, 2025 23:37
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@JoernBerkefeld JoernBerkefeld merged commit ae42d9b into develop Nov 25, 2025
9 checks passed
@JoernBerkefeld JoernBerkefeld deleted the feature/2427-allow-filtering-source-files-when-running-createdeltapackage branch November 25, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e/DevOps EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow filtering source files when running createDeltaPackage

2 participants