-
Notifications
You must be signed in to change notification settings - Fork 42
feature/2427 enhance filter logic to allow type-specific filters #2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/2427 enhance filter logic to allow type-specific filters #2435
Conversation
Coverage ReportCommit:912ab27Base: develop@34377da Details (changed files):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the filter logic to support type-specific filters in addition to global filters. Previously, filters could only be applied uniformly across all metadata types. Now, filters can be scoped to specific metadata types or applied globally using a wildcard "*" key.
Key Changes
- Introduced new
BuildFilterandBuildFilterKeystype definitions to support type-specific filtering - Refactored filtering logic into a dedicated
applyKeyFiltersmethod for better code organization - Enhanced filter structure to allow both global ("*") and type-specific filter keys
Reviewed changes
Copilot reviewed 3 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
types/mcdev.d.js |
Added JSDoc type definitions for BuildFilter and BuildFilterKeys to support the new filtering structure |
@types/types/mcdev.d.d.ts |
Generated TypeScript definitions for the new filter types |
@types/types/mcdev.d.d.ts.map |
Updated source map for TypeScript definitions |
lib/index.js |
Refactored filter logic into applyKeyFilters method with support for type-specific filters; updated method signatures to use BuildFilter type |
lib/util/devops.js |
Removed intermediate filter variable and directly passed sourceMarketLists.filter to build method |
@types/lib/index.d.ts |
Updated TypeScript method signatures to reflect BuildFilter parameter type |
@types/lib/index.d.ts.map |
Updated source map for index TypeScript definitions |
@types/lib/util/devops.d.ts |
Added BuildFilter type import |
@types/lib/util/devops.d.ts.map |
Updated source map for devops TypeScript definitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
PR details
What changes did you make? (Give an overview)
Further details (optional)
...
Checklist