feat: Implement the url property
#669
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I've tested this and it works correctly on macOS. I've updated simple.rs in the winit samples to create a link instead of button 2, then via ctrl + option + shift + u, Voice over now correctly announces the link URL. Without this patch it doesn't announce anything. |
Member
Author
|
It indeed does. Thank you @lukewarlow for teaching me how to use a screen reader! To be fair, I only use a Mac for testing purpose but couldn't find this shortcut in the documentation. Your help is much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find a screen reader that reports this one. I don't know if it is useful to other ATs. Servo will likely set it for link nodes.