Hayden - Edges / C10 - Bro Ranker by halcyon-and-on · Pull Request #28 · Ada-C10/MediaRanker

halcyon-and-on · 2018-10-15T05:53:27Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	The .spotlight self-method returns the highest voted medium.
Describe how you approached testing that model method. What edge cases did you come up with?	I realize now that I did not test any edge cases for that method. If none of my model instances have any votes however, it doesn't really matter which instance gets displayed as the spotlight. Likewise, if all medium instances were deleted it would crash the site but I avoided that by hiding the media spotlight code within a conditional.
What are `session` and `flash`? What is the difference between them?	Rails-provided hashlike objects. Session persists across a user's entire browsing session, flash only persists for one request-response cycle.
Describe a controller filter you wrote.	I pulled the medium find_by method calls out into a before_action
What was one thing that you gained more clarity on through this assignment?	I feel somewhat more comfortable just generally configuring rails backend stuff, which is good because I had felt uncomfortable with it previously.
What is the Heroku URL of your deployed application?	https://bro-ranker.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	Not really sorry

… enable media deletion, add routes for PagesController

…into different tables by category

…s_controller routing

…elper

tildeee · 2018-10-26T02:38:24Z

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	x
Comprehension questions	x
General
Rails fundamentals (RESTful routing, use of named paths)	x
Views are well-organized (DRY, use of semantic HTML, use of partials)	x
Errors are reported to the user	x
Business logic lives in the models	x
Models are thoroughly tested, including relations, validations and any custom logic	yes! thorough and well-done
Wave 1 - Media
Splash page shows the three media categories	x
Basic CRUD operations on media are present and functional	x
Wave 2 - Users and Votes
Users can log in and log out	x
The ID of the current user is stored in the session	x
A user cannot vote for the same media more than once	x
All media lists are ordered by vote count	x
Splash page contains a media spotlight	x
Wave 3 - Users and Votes
Media pages contain lists of voting users	x
Individual user pages and the user list are present	x
Optional - Styling
Bootstrap is used appropriately	x
Look and feel is similar to the original	x
Overall

Nicely done, Hayden! The code looks great, efficient, well-organized, and the site looks good too.

My comments are mostly small suggestions and questions.

I'm really impressed by how thorough and readable your tests are! They're great.

Overall, good work!

tildeee · 2018-10-26T02:39:04Z

app/helpers/media_helper.rb

+    return sorted.reverse!
+  end
+
+  def parse_bro_category(category)


Nice use of view helpers!

tildeee · 2018-10-26T02:39:30Z

app/models/medium.rb

+    self.all.max_by do |medium|
+      medium.votes.length
+    end
+  end


Fantastic! This is a great implementation of spotlight.

tildeee · 2018-10-26T02:39:48Z

app/views/media/index.html.erb

+  <section class="media-table">
+    <h4>Visual Bros</h4>
+    <%= render partial: "media_table", locals: { collection: order_by_votes(@movies) } %>
+  </section>


This view is already very clean code, as you made a good choice to pull out the media_table, but you could definitely find a way to push this so it's even shorter and cleaner ;)

tildeee · 2018-10-26T02:40:39Z

app/views/pages/home.html.erb

+    <ul class="list-group top-ten__list">
+      <%= render partial: 'medium', collection: first_ten_by_votes(@albums) %>
+    </ul>
+  </section>


There's a similar comment for another bit of view code, but there's definitely another way to reduce this code... Just a suggestion though.

tildeee · 2018-10-26T02:41:02Z

app/views/users/new.html.erb

+<article>
+  <h4>Bro, lemme be honest w you...</h4>
+  <p>
+    We literally have no idea how the internet works. We scraped most of the code for this app from StackOverflow posts, and I have actually used the same password for every single website I've logged into since 1998. Besides, the government doesn't even need to brute force your hashes, they INVENTED the encryption algorithms. You really think they wouldn't put a backdoor in there? Tor was invented by the Navy, lol.


tildeee · 2018-10-26T02:41:22Z

test/models/medium_test.rb

+        category: 'book',
+        creator: 'Jarth Dengees',
+        publication_year: 1999
+      )


Why not use an existing medium saved in the fixtures? (I definitely think that this is very readable though, so I won't fight for this very terribly, but the fixtures are definitely there already.)

halcyon-and-on added 30 commits October 8, 2018 15:47

rails init

8f0e2b3

generate controllers and models

efc7b09

drop screwy db and start from scratch; define relationships btwn models

4c484b8

seed db

a8d24e4

define initial routes and media_controller aactions

6358770

init media index and show views

f8c5689

init new media view

14f44eb

init media edit form, use partial

0dd9b75

add delete button to show page

653b029

generate PagesController, init homepage, fix foreign_keys on Votes to…

b8f4cd7

… enable media deletion, add routes for PagesController

add spotlight self method to Medium

3144d06

get media spotlight functioning on homepage

f5d57a2

extract media table rrows into partial

69b96e9

extract entire media table into its own partial

12d0a45

implement media table partials on homepage and media/index and split …

19ef152

…into different tables by category

add validations to User

0456721

add validations to Medium

18202e3

add creator validation to Medium

31cb8d2

add validation tests for Medium

4180858

add tests for relations and custom methods for Medium

53a7722

add User tests

ba0f6f6

add tests for vote model

cc2acdc

add new user route and create action to UsersController

ce975b5

add login functionality

a58e998

add logout functionality

deb2248

add login/logout functionality to primary layout

0406011

add primitive upvote functionality

eea20bc

prevent users from voting more than once per medium

6b025cd

move display logic from controllers into view helpers; pare down page…

87a0d16

…s_controller routing

slightly altered an error message and refactored one line in a view h…

ca958fd

…elper

halcyon-and-on added 17 commits October 13, 2018 20:24

extract votes table into partial; frefactor voting logic

18e06da

add user show page

153cdb4

add index page for users

ca087db

html for header and home page

35175a0

html for media index

2973a43

html for new medium form

3ef02c7

html for users index

6d57f82

html for login page

0ef0751

html for medium/user show pages and medium edit page

d3f7399

add find_by before_action to media controller

f5a80f8

steal css from sample site

58443ea

adjust upvote error message

2360da2

fixed some typos/a flash error message

dd361d7

make media_spotlight optional

35bdee4

added one more conditional to media_spotlight

ffe2695

fix new medium form typo

6d5f495

add error messages to new/edit medium

511f0e9

tildeee reviewed Oct 26, 2018

View reviewed changes

app/helpers/media_helper.rb

return sorted.reverse!

end

def parse_bro_category(category)

Copy link

tildeee Oct 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of view helpers!

tildeee reviewed Oct 26, 2018

View reviewed changes

app/models/medium.rb

self.all.max_by do |medium|

medium.votes.length

end

end

Copy link

tildeee Oct 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! This is a great implementation of spotlight.

tildeee reviewed Oct 26, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hayden - Edges / C10 - Bro Ranker#28

Hayden - Edges / C10 - Bro Ranker#28
halcyon-and-on wants to merge 47 commits intoAda-C10:masterfrom
halcyon-and-on:master

halcyon-and-on commented Oct 15, 2018

Uh oh!

tildeee commented Oct 26, 2018

Uh oh!

tildeee Oct 26, 2018

Uh oh!

tildeee Oct 26, 2018

Uh oh!

tildeee Oct 26, 2018

Uh oh!

tildeee Oct 26, 2018

Uh oh!

tildeee Oct 26, 2018

Uh oh!

tildeee Oct 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

halcyon-and-on commented Oct 15, 2018

Media Ranker

Comprehension Questions

Uh oh!

tildeee commented Oct 26, 2018

Media Ranker

What We're Looking For

Uh oh!

tildeee Oct 26, 2018

Choose a reason for hiding this comment

Uh oh!

tildeee Oct 26, 2018

Choose a reason for hiding this comment

Uh oh!

tildeee Oct 26, 2018

Choose a reason for hiding this comment

Uh oh!

tildeee Oct 26, 2018

Choose a reason for hiding this comment

Uh oh!

tildeee Oct 26, 2018

Choose a reason for hiding this comment

Uh oh!

tildeee Oct 26, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants